test(cuelite): add dedicated unit tests for 7 engine.go unexported helpers (plan 2606260615) - #703
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🔍 Merge Queue — bisecting A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 2 of 3 candidate PRs on Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch. |
|
⏳ Merge Queue — requeued The merge queue hit a transient error while processing this PR:
Next: No action needed — the queue will retry automatically on the next run. |
jeduden
added
queue:active
…lpers (plan 2606260615) Adds TestCombineMode, TestMkBottom, TestTopValue, TestEngineValue_IsBottomV, TestEngineValue_DefaultValue, TestEngineValue_DescribeBound, and TestBound_Describe in a new cue/cuelite/engine_helpers_test.go. Closes plan 2606260615 (filed by the 2026-06-26 architecture audit sweep). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YA8coRomPRZ9u51NjKeeMM
…o unexported helpers (plan 2606260615)
|
🔵 Merge Queue — CI running Merged into batch branch Next: No action needed — you'll be notified when CI completes. |
- Run mdsmith fix PLAN.md to add 2606260615 to the catalog (fixes mdsmith-fixed-version and mdsmith-check CI failures) - Add missing opNe+numeric test case to TestBound_Describe (the isStr=false code path in bound.describe was untested) - Use literal path in TestMkBottom to avoid aliasing false-positive Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YA8coRomPRZ9u51NjKeeMM
…ound 2 - Drop WHAT comments; keep two WHY comments (nil-safe contract, ambig semantics) - Convert TestEngineValue_DescribeBound to table-driven form (matches sibling style) - Add all six atomKind cases to DescribeBound table (akNumber/akBool/akBytes were untested) - Add second-branch-is-default subtest to TestEngineValue_DefaultValue so a reversed-index bug in defaultValue would fail Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YA8coRomPRZ9u51NjKeeMM
Round-3 review finding: assert.True used as a precondition before accessing v.reason/v.path/v.describe() and v2.path. Per CLAUDE.md "use require for preconditions and assert for checks" — and the same-package internal_test.go precedent — upgrade to require.True so a failing isBottomV() stops the test cleanly rather than letting secondary assertions run against an ill-formed value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YA8coRomPRZ9u51NjKeeMM
|
🔍 Merge Queue — bisecting A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 1 of 2 candidate PRs on Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch. |
The mdsmith v0.41.0 YAML parser mis-parses a colon inside a >- block folded scalar (e.g. "arch-fix: ..." on a continuation line) as a mapping key, producing "could not find expected ':'". Rewrote the title and summary to use only colon-free content in block scalars, matching the pattern used by all other plan files that pass the pinned-version CI check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YA8coRomPRZ9u51NjKeeMM
d617e4d to
7c6ee11
Compare
|
🔍 Merge Queue — bisecting A larger batch failed CI. Bisection is isolating the culprit: this run tests up to 1 of 1 candidate PRs on Next: No action needed — you'll be notified when the culprit is isolated, this PR merges, or this PR returns to the queue for a later batch. |
jeduden
removed
the
queue:active
|
✅ Merge Queue — merged This PR landed on Next: Done — nothing more to do here. |
The file was merged into main (PR #703) with unresolved conflict markers, breaking mdsmith-fixed-version, mdsmith-check, and bench-fragments CI jobs. Resolve by keeping the completed (✅) side: checked tasks, checked acceptance criteria, and the final title/status from the implementation run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012teDVC4T7vuxdaTBSBQ4nJ
2 participants
Summary
TestFunctionName-style unit tests for unexported helpers incue/cuelite/engine.gothat lacked per-function coverageTests added
TestCombineMode,TestMkBottom,TestTopValue,TestEngineValue_IsBottomV,TestEngineValue_DefaultValue,TestEngineValue_DescribeBound,TestBound_Describe— all in a newcue/cuelite/engine_helpers_test.go.Test plan
go test ./cue/cuelite/...greengo vet ./...cleango test ./...green (full suite)🤖 Generated with Claude Code
https://claude.ai/code/session_01YA8coRomPRZ9u51NjKeeMM
Generated by Claude Code